Update preview when file is updated in ImageEditor #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louis Chemineau <louis@chmn.me>
|
/backport to stable25 |
backportbot-nextcloud
bot
added
the
backport-request
artonge
added
bug
artonge
requested review from
skjnldsv,
a team,
Pytal and
szaimen
and removed request for
a team
artonge
commented
Feb 23, 2023
| @close="onClose" /> | ||
|
|
||
| <img v-else | ||
| <img v-else-if="data !== null" |
There was a problem hiding this comment.
Needed as we are using a concatenation for the src prop which seem to interfere with AsyncComputed logic.
The issue was that a request with null was sent instead of waiting for data to be initialized.
artonge
commented
Feb 23, 2023
| :alt="alt" | ||
| :class="{ | ||
| dragging, | ||
| loaded, | ||
| zoomed: zoomRatio !== 1 | ||
| }" | ||
| :src="data" | ||
| :src="`${data}${cacheBuster}`" |
There was a problem hiding this comment.
Simple approach, but it works. Sexier idea welcome. :)
This makes sure that the initial request can use the browser's cache, and that on an update the cache is busted with ?buster=1
skjnldsv
approved these changes
Feb 23, 2023
backportbot-nextcloud
bot
added
the
backport-request
1 task
backportbot-nextcloud
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After editing an image with the new editor, the preview stays the same when closing the editor. This PR makes sure that the preview will be updated.