Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(viewer): allow async handler components #2077

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

pulsejet
Copy link
Member

@pulsejet pulsejet commented Nov 27, 2023

Allows use of async handlers

OCA.Viewer.registerHandler({
	id: 'text',
	component: () => import('./components/ViewerComponent.vue'),
})

For nextcloud/text#4698

Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm, thanks for that 👍

@juliusknorr juliusknorr merged commit 15da8b5 into master Nov 28, 2023
27 checks passed
@juliusknorr juliusknorr deleted the pulsejet/async-handler branch November 28, 2023 08:29
@pulsejet
Copy link
Member Author

/backport to stable28

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Nov 29, 2023
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Nov 29, 2023
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants