fix: Adjust viewer for Nextcloud 31 public share UI #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
changed the title
|
/compile |
AndyScherzinger
approved these changes
Sep 6, 2024
susnux
force-pushed
the
fix/refactor-for-31
branch
from
5cf568a to
1bb601f
Compare
susnux
added
2. developing
skjnldsv
approved these changes
Sep 7, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/refactor-for-31
branch
from
1bb601f to
564b5c9
Compare
susnux
added
3. to review
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/refactor-for-31
branch
from
3e0d6f3 to
eb1380d
Compare
|
@susnux do we need this backported or is it only broken on master? |
No, this is only needed for 31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically every thing works out-of-the-box, except single file shares.
The source of the node, passed to the viewer by the files app, looks like this:
http://domain/public.php/dav/token.This results in
path = '/'.dirname = 'token',basename = 'token',displayName = 'real name.md'.That makes sense, but does not work as we then try to build
node.dirname/node.basenameas the path which results intoken/token❌ wrong.So instead just rely on
node.path, this works for all public shares and also for internal files (did not test group folders but why should that not work?).Except from that I removed all the legacy FileList bindings as they do not exist anymore. And refactored the files integration using Typescript.