Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] fix: Hide download action when file does not provide download permissions #2524

Draft
wants to merge 1 commit into
base: stable30
Choose a base branch
from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Sep 15, 2024

Backport of #2482

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

…ions

This is not only a possibility for public shares but also for internal shares,

the current code only "checked" public shares.

This adds the same logic we use in the files app. Probably something to move to

`@nextcloud/sharing` but for the moment lets just reuse here.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

[skip ci]
@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews labels Sep 15, 2024
@backportbot backportbot bot added this to the Nextcloud 30.0.1 milestone Sep 15, 2024
@Koc
Copy link

Koc commented Nov 14, 2024

@skjnldsv can we merge this, please? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants