Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Updatenotification #2461

Merged
merged 12 commits into from
Apr 1, 2023
Merged

Change Updatenotification #2461

merged 12 commits into from
Apr 1, 2023

Conversation

enoch85
Copy link
Member

@enoch85 enoch85 commented Mar 31, 2023

Follow up on: 7c7b5f5

@szaimen Any thoughts on this? I ask becasue you implemented it.

My idea here is to run updates less frequently. Once per month is enough.

Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
@enoch85 enoch85 requested a review from szaimen March 31, 2023 11:49
@szaimen
Copy link
Collaborator

szaimen commented Mar 31, 2023

Hm... Is there a specific reason why the update script should only run once a month and not every week? This means some instances might be vulnerable in worst case for a whole month without any updates installed...

@enoch85
Copy link
Member Author

enoch85 commented Mar 31, 2023

Hm... Is there a specific reason why the update script should only run once a month and not every week? This means some instances might be vulnerable in worst case for a whole month without any updates installed...

Yes, it's about uptime. I'm aware of the downside, but if you want to update more frequently then you can just change the crontab. Once per month is enough from a security standpoint if you ask me. In worst case, some CVE might not be patched instantly (aka next week) but 3 weeks more is not a problem I'd say - maybe if you're a government, but not a "regular user".

nextcloud_install_production.sh Outdated Show resolved Hide resolved
nextcloud_update.sh Show resolved Hide resolved
nextcloud_update.sh Outdated Show resolved Hide resolved
static/updatenotification.sh Show resolved Hide resolved
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if you really want to change it to monthly adjusting only the wording shoupd be enough

Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
@enoch85 enoch85 merged commit 197e233 into master Apr 1, 2023
@delete-merged-branch delete-merged-branch bot deleted the updatenotification branch April 1, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants