Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Imaginary values #2479

Merged
merged 4 commits into from
Apr 27, 2023
Merged

Update Imaginary values #2479

merged 4 commits into from
Apr 27, 2023

Conversation

enoch85
Copy link
Member

@enoch85 enoch85 commented Apr 27, 2023

cc @szaimen Your take on this?

It's according to docs. Are there more formats supported by Imagniary? I saw that Krita was another supported format?

@enoch85
Update Imaginary values
6d09eda 
cc  @szaimen Your take on this?

It's according to docs. Are there more formats supported by Imagniary? I saw that Krita was another supported format?

Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
szaimen
szaimen reviewed Apr 27, 2023
View reviewed changes
apps/imaginary.sh Outdated Show resolved Hide resolved
szaimen
szaimen reviewed Apr 27, 2023
View reviewed changes
apps/imaginary.sh Outdated Show resolved Hide resolved
@enoch85 @szaimen
Update apps/imaginary.sh
107b24c 
Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
@enoch85
Copy link
Member Author

enoch85 commented Apr 27, 2023

Why not PDF and HEIC? I saw that you added support for PDF in the last release.

@enoch85 @szaimen
Update apps/imaginary.sh
8276eb0 
Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
@szaimen
Copy link
Collaborator

szaimen commented Apr 27, 2023

Why not PDF and HEIC? I saw that you added support for PDF in the last release.

because it is already included here: https://github.com/nextcloud/server/blob/5e96228eb1f7999a327dacab22055ec2aa8e28a3/lib/private/Preview/Imaginary.php#L60

@enoch85
Copy link
Member Author

enoch85 commented Apr 27, 2023

Why not PDF and HEIC? I saw that you added support for PDF in the last release.

because it is already included here: https://github.com/nextcloud/server/blob/5e96228eb1f7999a327dacab22055ec2aa8e28a3/lib/private/Preview/Imaginary.php#L60

Ah ok, but still strange that PDFs weren't generated without adding it as enabled. I'll need to double check.

Anyway, are there any more formats that can be enabled?

@szaimen
Copy link
Collaborator

szaimen commented Apr 27, 2023

Anyway, are there any more formats that can be enabled?

Probably Krita indeed as it is not covered by imaginary.

@enoch85
add krita
98396dc 
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
szaimen
szaimen approved these changes Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enoch85 enoch85 merged commit 6772a66 into master Apr 27, 2023
@delete-merged-branch delete-merged-branch bot deleted the imaginary-fixes branch April 27, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enoch85 @szaimen