Implement Talk recording #2520
Implement Talk recording #2520
Conversation
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Co-authored-by: Simon L. <szaimen@e.mail.de> Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
|
@szaimen What do you think? Did I understand you correctly or is something wrong here? Not tested. |
lgtm in general. However If you compare the talk-hpb with https://github.com/nextcloud/all-in-one/blob/main/Containers/talk/start.sh, the turn section can be removed |
Co-authored-by: Simon L. <szaimen@e.mail.de> Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Co-authored-by: Simon L. <szaimen@e.mail.de> Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Co-authored-by: Simon L. <szaimen@e.mail.de> Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Hmm, not so sure about that. I've seen it in an enterprise setup as well. As you already know, we use @morph027 setup for Signaling, and the I suppose you mean this: https://github.com/nextcloud/vm/blob/master/apps/talk.sh#L341-L343 |
yes |
I'll leave it, don't know the side effects if I remove it. |
The side-effect of leaving it could be that the recording server does not work. |
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
Actually, we have that in another setup (not your container, and my colleges installation), and it's working there. Do you mean that your container doesn't handle it, or what's the reason for it stop working? Also, it should only be removed if talk recording is turned on? |
The config is simply wrong as far as I know. The talk-hpb does not need a turn server afaik. Turn is only used by the android and ios apps directly. |
Can you give your take on this? I will merge this now for easier testing. We can continue the discussion in this PR though. |
Fix #2519
cc @szaimen