Use viewer api to to enable customization of markdown nodes #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by defaulting to a <span> element to host reagent dangerously-set inline HTML
1 task
CleanShot.2022-03-24.at.18.45.08.mp4 |
zampino
force-pushed
the
described-markdown-II
branch
from
bdbbaf0 to
b8b56d4
Compare
Evaluating the inspect function on edamame read instead of having to deal with ifns seems to make Reagent happier.
|
I do not completely grasp why fe1e9a6 fixes the in-text slider re-rendering issue, but the reagent structure in devtools shows that with
|
zampino
force-pushed
the
described-markdown-II
branch
from
e3d99a4 to
1ee6b2c
Compare
zampino
commented
Mar 30, 2022
deps.edn
Outdated
| io.github.nextjournal/viewers {:git/sha "d88a9abd1f2bfd28ff2d3983407a9319c6f04501"} | ||
| io.github.nextjournal/viewers {:git/sha "d88a9abd1f2bfd28ff2d3983407a9319c6f04501" | ||
| :exclusions [io.github.nextjournal/markdown | ||
| io.github.nextjournal/clerk]} |
There was a problem hiding this comment.
👆 these redundant deps confuse my intellij, can we exclude them?
There was a problem hiding this comment.
Let's remove those from the viewers so it doesn't bring both of those in.
zampino
force-pushed
the
described-markdown-II
branch
from
81ef1ed to
359761c
Compare
mk
reviewed
Apr 4, 2022
deps.edn
Outdated
| io.github.nextjournal/viewers {:git/sha "d88a9abd1f2bfd28ff2d3983407a9319c6f04501"} | ||
| io.github.nextjournal/viewers {:git/sha "d88a9abd1f2bfd28ff2d3983407a9319c6f04501" | ||
| :exclusions [io.github.nextjournal/markdown | ||
| io.github.nextjournal/clerk]} |
There was a problem hiding this comment.
Let's remove those from the viewers so it doesn't bring both of those in.
notebooks/described_markdown.clj
Outdated
| (with-md-viewer (parse text)))) | ||
|
|
||
| (reset! nextjournal.clerk.webserver/!doc nextjournal.clerk.webserver/help-doc) | ||
| (reset! v/!viewers (v/get-all-viewers))) |
src/nextjournal/clerk/viewer.cljc
Outdated
| {:name :nextjournal.markdown/sidenote | ||
| :transform-fn (into-markup (fn [{:keys [attrs]}] [:span.sidenote [:sup {:style {:margin-right "3px"}} (-> attrs :ref inc)]]))} | ||
| {:name :nextjournal.markdown/sidenote-ref | ||
| :transform-fn (into-markup [:sup.sidenote-ref])} |
we'll deal with this by removing clerk and markdown from the root deps of viewers
mk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This processes the parsed markdown nodes through the viewer api, enabling the same customization as for results. In addition, folks can extend the markdown tokenization and use the JVM-parts of the viewer api (
:fetch-fnand:transform-fn) to introduce new behavior.CleanShot.2022-03-30.at.09.42.30.mp4