Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file picker to splash page #77

Merged
merged 4 commits into from
Dec 28, 2023
Merged

Add file picker to splash page #77

merged 4 commits into from
Dec 28, 2023

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Dec 14, 2023

(preview)

Description of proposed changes

See commit messages.

Related issue(s)

Checklist

@victorlin victorlin self-assigned this Dec 14, 2023
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-us-victorlin-fi-eroixj December 14, 2023 01:07 Inactive
@victorlin victorlin force-pushed the victorlin/file-picker branch from c6b195a to 3b936c3 Compare December 14, 2023 18:30
@victorlin victorlin temporarily deployed to auspice-us-victorlin-fi-eroixj December 14, 2023 18:30 Inactive
@victorlin victorlin force-pushed the victorlin/file-picker branch from 3b936c3 to 2e3c8ff Compare December 26, 2023 20:20
@victorlin victorlin temporarily deployed to auspice-us-victorlin-fi-fctib2 December 26, 2023 21:04 Inactive
The last reference removed in "Remove server functionality" (3a7333a).
Following official docs.¹

Motivation: the next commit "Add file picker" does not seem to work
as-is on a class component, and I couldn't figure out why. Converting
makes it possible.

¹ <https://react.dev/reference/react/Component#migrating-a-component-with-lifecycle-methods-from-a-class-to-a-function>
@victorlin victorlin force-pushed the victorlin/file-picker branch from 2e3c8ff to 0db85e4 Compare December 26, 2023 21:17
@victorlin victorlin temporarily deployed to auspice-us-victorlin-fi-fctib2 December 26, 2023 21:17 Inactive
@victorlin victorlin changed the title Add file picker Add file picker to splash page Dec 26, 2023
@victorlin victorlin merged commit 4c2b79f into master Dec 28, 2023
1 check passed
@victorlin victorlin deleted the victorlin/file-picker branch December 28, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants