Skip to content

Commit

Permalink
Combine build and smoke-test jobs
Browse files Browse the repository at this point in the history
smoke-test already does everything that build does, so build is
redundant.
  • Loading branch information
victorlin committed Nov 21, 2024
1 parent 7c0cd44 commit 431b58d
Showing 1 changed file with 2 additions and 15 deletions.
17 changes: 2 additions & 15 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,6 @@ on:
name: ci

jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
node: [16, 18, 20, 22]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
- run: node --version
# Build is implicit with the "prepare" life cycle script
- run: npm ci --loglevel verbose

unit-test:
runs-on: ubuntu-latest
strategy:
Expand All @@ -39,7 +25,7 @@ jobs:
- run: npm ci --loglevel verbose --ignore-scripts
- run: npm test

smoke-test:
build-and-smoke-test:
runs-on: ubuntu-latest
strategy:
matrix:
Expand All @@ -49,6 +35,7 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
# Build is implicit with the "prepare" life cycle script
- run: npm ci --loglevel verbose
- run: npm run get-data
- run: npx playwright install chromium
Expand Down

0 comments on commit 431b58d

Please sign in to comment.