Tidy up Event listener when unmounting #1178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
What is the goal of this pull request? What does this pull request change?
we need to tidy up when unmounting
Related issue(s)
Fixes #
Related to # 1115
Testing
What steps should be taken to test the changes you've proposed?
monitor.js responds to browser window resizing? So a hasty test would be to resize the window and check that every displayed element still works. Also, watch the memory usage and browser console.
I also ran the code through Deepscan. It was previously flagging an error here, but no longer.
If you added or changed behavior in the codebase, did you update the tests, or do you need help with this?
Yes, I would like help with tests!
Please review the code, I am new to lodash throttle cancel. @dos077 @jameshadfield
If you are not confident in this code then we need to shelve it until we understand it better.
Thank you for contributing to Nextstrain!