Make icons change layout too [#1911] #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
auspice-make-grid-full--twbgmz
victorlin
reviewed
Nov 20, 2024
genehack
force-pushed
the
make-grid-full-icons-work-1911
branch
from
d4688c0 to
400d5ee
Compare
genehack
force-pushed
the
make-grid-full-icons-work-1911
branch
from
400d5ee to
6c2bfd6
Compare
genehack
force-pushed
the
make-grid-full-icons-work-1911
branch
from
6c2bfd6 to
7971a1e
Compare
Added & force-pushed — in a "NEXT" section, as I don't think this change by itself deserves a release? |
|
No need for a new section header, it is automatically added in the release script: Line 80 in bf24816 |
This leads to a slight styling change, but is probably Close Enough™
genehack
force-pushed
the
make-grid-full-icons-work-1911
branch
from
7971a1e to
261b86a
Compare
|
ah, okay, cool, removed, re-pushed. |
victorlin
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR adds wrapping
<span>s to the grid/full buttons in the layout sub-panel, so clicking the icons changes the layout, just like clicking the words.Related issue(s)
Closes #1911
Checklist