gatsby groups page parse markdown overview; #315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this uses some recent work on the static site to render splash pages for nextstrain groups using the gatsby server and the new dataset select interface. Still to be addressed: - General UI improvements such as rendering custom markdown from each group and removing possibly redundant info in the dataset/narrative listings (e.g. contributor, the word dataset in the case of using the dataset-select UI for narratives) - getting access denied on s3 request for custom group info (even in cases where it works on nextstrain.org) - getting internal error in handling getAvailable request like: /charon/getAvailable?prefix=/groups/swiss/ - improve promise logic in componentDidMount - more testing in general
this separates concerns and error handling of separate requests and promises for the sourceInfo and getAvailable requests
allow showing the sourceInfo without having loading datasets
Copies the approach of auspice, previously done by auspice-client/customisations/splash.js. That page will be retired once gatsby performs all the necessary function to handle routing to either gatsby landing pages or to auspice.
eharkins
force-pushed
the
individual-group-page
branch
3 times, most recently
from
ce29c44 to
bbbb508
Compare
eharkins
force-pushed
the
individual-group-page
branch
from
b335573 to
0fd8ed8
Compare
|
Superseded by #345 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies the approach of auspice,
previously done by
auspice-client/customisations/splash.js.
That page will be retired once gatsby
performs all the necessary function to
handle routing to either gatsby landing
pages or to auspice.
dompurifywhich i am trying to sort out.