Move Auspice dep from the server code to the auspice-client customizations #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the only reason for the server code to depend on Auspice. This function hasn't changed in Auspice in over 2 years and is unlikely to in the future. It seems to me that we're more likely to drop backwards compat with v1 first.
tsibley
added a commit
to nextstrain/auspice
that referenced
this pull request
Apr 6, 2023
…for Auspice move there Related-to: <nextstrain/nextstrain.org#673>
2 tasks
tsibley
force-pushed
the
trs/move-auspice-dep
branch
from
9ddce20 to
497b42c
Compare
tsibley
force-pushed
the
trs/move-auspice-dep
branch
from
497b42c to
36e511c
Compare
victorlin
approved these changes
Apr 7, 2023
tsibley
force-pushed
the
trs/move-auspice-dep
branch
from
36e511c to
6dc47dc
Compare
…tions Avoids bringing in all of Auspice's deps into the server code. This is generally useful, but it was also specifically useful in recent prototyping to allow use of React 18 server components (as Auspice requires React 16). In any case, I think organizationally this makes more sense anyway. Related-to: <nextstrain/auspice#1661>
tsibley
force-pushed
the
trs/move-auspice-dep
branch
from
6dc47dc to
3205a85
Compare
|
So my first fix worked in CI… but failed locally when I tested it. That's because I tested it by doing: which failed when the Gatsby build couldn't find the I fixed it again by moving that dep into auspice-client, which works locally with the above test. As long as CI passes now, I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
Related issue(s)
nextstrain/auspice#1661
Testing