Skip to content

Commit

Permalink
refactor(.github): github action warnings (#3317)
Browse files Browse the repository at this point in the history
* chore(.github): bump action versions

* refactor(autocomplete): linting

* chore(.github): without version
  • Loading branch information
wingkwong authored Jun 25, 2024
1 parent 4218335 commit 720f2f5
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 15 deletions.
6 changes: 2 additions & 4 deletions .github/common-actions/install/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,10 @@ runs:
using: composite
steps:
- name: Install dependencies
uses: pnpm/action-setup@v2.2.4
with:
version: 8
uses: pnpm/action-setup@v4

- name: Setup Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version-file: ".nvmrc"
registry-url: "https://registry.npmjs.org"
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/QA.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout branch
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install
uses: ./.github/common-actions/install
Expand All @@ -24,7 +24,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout branch
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install
uses: ./.github/common-actions/install
Expand All @@ -37,7 +37,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout branch
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install
uses: ./.github/common-actions/install
Expand All @@ -50,7 +50,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout branch
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install
uses: ./.github/common-actions/install
Expand All @@ -63,7 +63,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout branch
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install
uses: ./.github/common-actions/install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout branch
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install
uses: ./.github/common-actions/install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sync-canary-to-main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0 # Ensure all history is fetched

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,8 @@ const itemsSectionData = [
},
];


const ControlledAutocomplete = <T = object>(props: AutocompleteProps<T>) => {
const [selectedKey, setSelectedKey] = React.useState<React.Key>("cat");
const ControlledAutocomplete = <T extends object>(props: AutocompleteProps<T>) => {
const [selectedKey, setSelectedKey] = React.useState<React.Key | null>("cat");

return (
<Autocomplete
Expand All @@ -77,7 +76,6 @@ const AutocompleteExample = (props: Partial<AutocompleteProps> = {}) => (
</Autocomplete>
);


describe("Autocomplete", () => {
it("should render correctly", () => {
const wrapper = render(<AutocompleteExample />);
Expand Down

0 comments on commit 720f2f5

Please sign in to comment.