fix(switch): the group has been replaced with a switch group in toggle #2989

novsource · 2024-05-12T18:14:11Z

📝 Description

Fixed a styles bug where the state of the Switch group takes the value of the data attribute data-selected from the elements above

⛳️ Current behavior (updates)

Testing code

<div className="flex gap-x-6">
     <Table selectionMode="multiple">
        <TableHeader>
          <TableColumn>Fixed switch</TableColumn>
        </TableHeader>
        <TableBody>
          <TableRow>
            <TableCell>
              <Switch />
            </TableCell>
          </TableRow>
        </TableBody>
      </Table>

      <div
        id="selected-div"
        className="group px-6 border-2 border-dashed rounded-small"
        data-selected="false"
      >
        <div className="flex gap-x-4 items-center h-full">
          <Switch />
          <button
            className="bg-default-700"
            onClick={() => {
              const attr = "data-selected";
              const el = document.getElementById("selected-div");

              const selected = el?.getAttribute(attr);

              el?.setAttribute(attr, selected === "false" ? "true" : "false");
            }}
          >
            Toggle div data selected
          </button>
        </div>
      </div>
    </div>

Before.video.mp4

🚀 New behavior

After.mp4

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Summary by CodeRabbit

Bug Fixes
- Fixed a styling issue in the Switch component to ensure visual consistency across different states.
Style Updates
- Enhanced toggle button styles for clearer state differentiation including default, primary, secondary, success, warning, and danger states.

…e styles

changeset-bot · 2024-05-12T18:14:15Z

🦋 Changeset detected

Latest commit: eecc201

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@nextui-org/theme	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-05-12T18:14:16Z

Someone is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

vercel · 2024-05-12T18:14:17Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 13, 2024 11:38am

coderabbitai · 2024-05-12T18:14:38Z

Walkthrough

The patch enhances the @nextui-org/theme package by resolving a style bug associated with the Switch component within a table that erroneously toggles state when a row is selected. Notably, the toggle.ts file undergoes modifications to provide clearer differentiation of CSS class names for various states.

Changes

File Path	Change Summary
`.changeset/giant-kids-march.md`	Introduced a patch to fix a style bug related to the `Switch` group's state.
`packages/core/theme/src/components/toggle.ts`	Updated CSS classes for toggle states (default, primary, etc.) to include `/switch` for improved clarity.

Assessment against linked issues

Objective	Addressed	Explanation
Bug fix for the `Switch` component toggling on row selection (#2959)	✅
Ensure no changes to exported or public entities affecting external dependencies	✅
Clarify CSS class naming for different states in the `Switch` component	✅
Address unexpected behavior regardless of the `Switch` state	❌	The summary lacks explicit confirmation of handling `Switch` state consistency.
Maintain compatibility with existing CSS structure	❓	While class names are updated for clarity, the impact on existing setups remains uncertain.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 633f9d2 and e8e7139.

Files selected for processing (2)

.changeset/giant-kids-march.md (1 hunks)
packages/core/theme/src/components/toggle.ts (7 hunks)

Files skipped from review due to trivial changes (1)

.changeset/giant-kids-march.md

Additional comments not posted (5)

packages/core/theme/src/components/toggle.ts (5)

33-33: The update to the base slot class name enhances specificity and should help prevent style conflicts. Good improvement.

66-97: The introduction of specific class names for the wrapper slot based on the selected attribute directly addresses the issue of the switch's state being influenced by parent elements. This is a crucial fix for the reported bug.

Line range hint 107-129: Adjustments to the margin-left of the thumb slot across different sizes ensure that the visual state of the switch is consistent and clear. This enhances user experience by providing immediate visual feedback.

153-160: The modifications to the disableAnimation variants introduce smoother transitions and visual effects based on the selected state, contributing to a more intuitive and responsive user interface.

176-199: The updates to the compoundVariants introduce specific width adjustments for the thumb based on the pressed state, enhancing the component's interactivity and providing accurate visual feedback during user interactions.

wingkwong

please add some tests
please share the code you tested with

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e8e7139 and eecc201.

Files selected for processing (1)

.changeset/giant-kids-march.md (1 hunks)

Files skipped from review as they are similar to previous changes (1)

.changeset/giant-kids-march.md

wingkwong · 2024-08-21T03:28:35Z

closing - will be covered in #3658

fix(switch): the group has been replaced with a switch group in toggl…

e8e7139

…e styles

novsource requested a review from jrgarciadev as a code owner May 12, 2024 18:14

vercel bot deployed to Preview – nextui-storybook-v2 May 12, 2024 18:16 View deployment

coderabbitai bot reviewed May 12, 2024

View reviewed changes

chore(changeset): add issue number

eecc201

wingkwong requested changes May 13, 2024

View reviewed changes

wingkwong added the 🚧 Status: Changes Requested label May 13, 2024

vercel bot deployed to Preview – nextui-storybook-v2 May 13, 2024 11:38 View deployment

coderabbitai bot reviewed May 13, 2024

View reviewed changes

wingkwong closed this Aug 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(switch): the group has been replaced with a switch group in toggle #2989

fix(switch): the group has been replaced with a switch group in toggle #2989

novsource commented May 12, 2024 •

edited

Loading

changeset-bot bot commented May 12, 2024 •

edited

Loading

vercel bot commented May 12, 2024

vercel bot commented May 12, 2024 •

edited

Loading

coderabbitai bot commented May 12, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

wingkwong left a comment

coderabbitai bot left a comment

wingkwong commented Aug 21, 2024

fix(switch): the group has been replaced with a switch group in toggle #2989

fix(switch): the group has been replaced with a switch group in toggle #2989

Conversation

novsource commented May 12, 2024 • edited Loading

📝 Description

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

changeset-bot bot commented May 12, 2024 • edited Loading

🦋 Changeset detected

vercel bot commented May 12, 2024

vercel bot commented May 12, 2024 • edited Loading

coderabbitai bot commented May 12, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

wingkwong left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

wingkwong commented Aug 21, 2024

novsource commented May 12, 2024 •

edited

Loading

changeset-bot bot commented May 12, 2024 •

edited

Loading

vercel bot commented May 12, 2024 •

edited

Loading

coderabbitai bot commented May 12, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)