Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): added missing package manager tabs in cli docs #3606

Closed
wants to merge 9 commits into from

Conversation

awesome-pro
Copy link
Contributor

@awesome-pro awesome-pro commented Aug 4, 2024

Closes #3605

📝 Description

Add missing different package manager tabs

⛳️ Current behavior (updates)

Screenshot 2024-08-04 at 7 16 46 PM Screenshot 2024-08-04 at 7 29 26 PM

🚀 New behavior

Screenshot 2024-08-04 at 7 14 32 PM Screenshot 2024-08-04 at 7 17 19 PM

💣 Is this a breaking change (Yes/No): NO

📝 Additional Information

Summary by CodeRabbit

  • New Features

    • Introduced a new <PackageManagers> component for improved presentation of package manager commands in the documentation.
    • Updated installation and server start commands to utilize the <PackageManagers> component, enhancing clarity and consistency.
  • Documentation

    • Replaced inline code blocks with the <PackageManagers> component in documentation for better readability and maintainability.

Copy link

changeset-bot bot commented Aug 4, 2024

⚠️ No Changeset found

Latest commit: 9d35f93

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 4, 2024

@awesome-pro is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Aug 4, 2024

Warning

Rate limit exceeded

@awesome-pro has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 44 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 4bce545 and 9d35f93.

Walkthrough

The recent changes enhance the NextUI documentation by replacing inline code blocks with a new PackageManagers component. This component structures commands for various package managers (npm, yarn, pnpm, bun) for installing dependencies and starting the local server, improving readability, maintainability, and user experience.

Changes

Files Change Summary
.../guide/cli.mdx Replaced inline code blocks with PackageManagers component for CLI commands.
.../guide/installation.mdx Encapsulated installation and server start commands in PackageManagers for better structure.

Assessment against linked issues

Objective Addressed Explanation
Add support for additional package runners (3605)
Enhance command presentation for package managers (3605)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6d9995b and 3a2ded2.

Files selected for processing (2)
  • apps/docs/content/docs/guide/cli.mdx (2 hunks)
  • apps/docs/content/docs/guide/installation.mdx (1 hunks)
Files skipped from review due to trivial changes (1)
  • apps/docs/content/docs/guide/cli.mdx
Additional comments not posted (2)
apps/docs/content/docs/guide/installation.mdx (2)

42-49: Verify the correctness of installation commands.

Ensure the commands for each package manager correctly install dependencies in the my-nextui-app directory.

Verification successful

Verified: Correct installation commands.

The installation commands for each package manager correctly install dependencies in the my-nextui-app directory.

  • npm: cd my-nextui-app && npm install
  • yarn: cd my-nextui-app && yarn install
  • pnpm: cd my-nextui-app && pnpm install
  • bun: cd my-nextui-app && bun install
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the installation commands for each package manager.

# Test: Search for the installation commands. Expect: Correct commands for each package manager.
rg --type mdx -A 5 $'<PackageManagers\n  commands={{\n    npm: "cd my-nextui-app && npm install",\n    yarn: "cd my-nextui-app && yarn install",\n    pnpm: "cd my-nextui-app && pnpm install",\n    bun: "cd my-nextui-app && bun install",\n  }}\n/>'

Length of output: 733


Script:

#!/bin/bash
# Description: Verify the installation commands for each package manager.

# Test: Search for the installation commands. Expect: Correct commands for each package manager.
rg --type mdx -A 5 $'<PackageManagers\n  commands={{\n    npm: "cd my-nextui-app \\&\\& npm install",\n    yarn: "cd my-nextui-app \\&\\& yarn install",\n    pnpm: "cd my-nextui-app \\&\\& pnpm install",\n    bun: "cd my-nextui-app \\&\\& bun install",\n  }}\n/>'

Length of output: 749


Script:

#!/bin/bash
# Description: Verify the installation commands for each package manager.

# Test: Search for the <PackageManagers> component. Expect: Correct commands for each package manager.
rg --type mdx -A 10 '<PackageManagers'

Length of output: 68


Script:

#!/bin/bash
# Description: Verify the installation commands for each package manager.

# Test: Search for the <PackageManagers> component. Expect: Correct commands for each package manager.
rg -A 10 '<PackageManagers'

Length of output: 75629


52-59: Verify the correctness of server start commands.

Ensure the commands for each package manager correctly start the local server.

Verification successful

Correct the regex pattern and re-run the verification script.

The previous regex pattern contained an error. Let's correct it and verify the server start commands again.


Correct the regex pattern by escaping curly braces and re-run the verification script.

The previous regex pattern contained an error due to unescaped curly braces. Let's correct it and verify the server start commands again.


Enable multiline mode in the regex pattern and re-run the verification script.

The previous regex pattern contained an error due to literal new line characters. Let's enable multiline mode and verify the server start commands again.


Remove file type specification and re-run the verification script.

The previous script failed because mdx is not recognized as a valid file type. Let's search all files for the pattern.


The server start commands are correct.

The commands for each package manager correctly start the local server as specified.

  • npm: npm run dev
  • yarn: yarn run dev
  • pnpm: pnpm run dev
  • bun: bun run dev
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the server start commands for each package manager.

# Test: Search for the server start commands. Expect: Correct commands for each package manager.
rg --type mdx -A 5 $'<PackageManagers\n  commands={{\n    npm: "npm run dev",\n    yarn: "yarn run dev",\n    pnpm: "pnpm run dev",\n    bun: "bun run dev",\n  }}\n/>'

Length of output: 573


Script:

#!/bin/bash
# Description: Verify the server start commands for each package manager.

# Test: Search for the server start commands. Expect: Correct commands for each package manager.
rg --type mdx -A 5 $'<PackageManagers\n  commands={{\n    npm: "npm run dev",\n    yarn: "yarn run dev",\n    pnpm: "pnpm run dev",\n    bun: "bun run dev",\n  }}\n/>'

Length of output: 573


Script:

#!/bin/bash
# Description: Verify the server start commands for each package manager.

# Test: Search for the server start commands. Expect: Correct commands for each package manager.
rg --type mdx -A 5 $'<PackageManagers\n  commands=\\{\\{\n    npm: "npm run dev",\n    yarn: "yarn run dev",\n    pnpm: "pnpm run dev",\n    bun: "bun run dev",\n  \\}\\}\n/>'

Length of output: 357


Script:

#!/bin/bash
# Description: Verify the server start commands for each package manager.

# Test: Search for the server start commands. Expect: Correct commands for each package manager.
rg --multiline --type mdx -A 5 $'<PackageManagers\n  commands=\\{\\{\n    npm: "npm run dev",\n    yarn: "yarn run dev",\n    pnpm: "pnpm run dev",\n    bun: "bun run dev",\n  \\}\\}\n/>'

Length of output: 205


Script:

#!/bin/bash
# Description: Verify the server start commands for each package manager.

# Test: Search for the server start commands. Expect: Correct commands for each package manager.
rg --multiline -A 5 $'<PackageManagers\n  commands=\\{\\{\n    npm: "npm run dev",\n    yarn: "yarn run dev",\n    pnpm: "pnpm run dev",\n    bun: "bun run dev",\n  \\}\\}\n/>'

Length of output: 1837

Copy link

vercel bot commented Aug 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2024 3:42pm

Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L33 needs to be updated as well.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3a2ded2 and 4bce545.

Files selected for processing (1)
  • apps/docs/content/docs/guide/cli.mdx (2 hunks)
Files skipped from review due to trivial changes (1)
  • apps/docs/content/docs/guide/cli.mdx

@wingkwong wingkwong assigned jrgarciadev and unassigned awesome-pro Aug 5, 2024
@wingkwong wingkwong added this to the v2.5.0 milestone Aug 5, 2024
@wingkwong wingkwong assigned awesome-pro and unassigned jrgarciadev Aug 10, 2024
Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why reverting all changes?

@awesome-pro
Copy link
Contributor Author

awesome-pro commented Aug 10, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: add more package runners
4 participants