fix(calendar): arrows changing order when html has dir="rtl"

[ameybh]

Closes #3641 #3642

📝 Description

⛳️ Current behavior (updates)

As described in #3641, currently, if the html has dir attribute equal to rtl, the arrow keys look incorrect.

🚀 New behavior

Added order to prevButton, nextButton and header . Added rtl:flex-row-reverse to headerWrapper.
The prev button should always be a left arrow and the next button should always be a right arrow, hence removed condition that changed arrow type based on locale direction.

Calendar with dir="rtl"

Date Picker with dir="rtl"

💣 Is this a breaking change (Yes/No):

No.

[changeset-bot]

🦋 Changeset detected

Latest commit: 0e7102a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@nextui-org/calendar	Patch
@nextui-org/date-picker	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

@ameytessact is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

This update enhances the @nextui-org/calendar package by improving support for right-to-left (RTL) layouts. It addresses arrow key navigation issues to align with RTL behavior, enhancing accessibility for keyboard users. Additionally, it simplifies the CalendarBase component by removing dependency on locale-based directionality, and it improves the styling of the calendar to ensure proper visual arrangement in RTL contexts.

Changes

Files	Change Summary
.changeset/sixty-games-wait.md	AI-generated summary of changes focusing on RTL support and usability improvements.
calendar-base.tsx	Removed dependency on useLocale, simplifying button rendering.
calendar.ts	Updated styling and layout for buttons and header in RTL format, ensuring correct visual order.

Assessment against linked issues

Objective	Addressed	Explanation
Lack of RTL Support in Calendar (#3641)	✅
Arrow key navigation in RTL context (#3641)	✅
Usability impact for right-to-left language users	❌	Simplification may affect RTL usability.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1973864 and 0e7102a.

Files selected for processing (3)

• .changeset/sixty-games-wait.md (1 hunks)
• packages/components/calendar/src/calendar-base.tsx (4 hunks)
• packages/core/theme/src/components/calendar.ts (1 hunks)

Additional comments not posted (3)

.changeset/sixty-games-wait.md (1)

1-5: Changeset is well-written and clear.

The changeset provides a concise description of the patch update for fixing arrow key order in RTL layouts.

packages/components/calendar/src/calendar-base.tsx (1)

Line range hint 72-86: Verify RTL usability impact.

The removal of locale-based directionality simplifies the logic but may affect RTL usability. Ensure thorough testing in RTL contexts to confirm the expected behavior.

packages/core/theme/src/components/calendar.ts (1)

13-24: Styling changes enhance RTL support.

The explicit ordering and rtl:flex-row-reverse class improve RTL layout handling. Ensure that these changes are covered by RTL-specific tests.