-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs) routing.mdx #4097
fix(docs) routing.mdx #4097
Conversation
* chore(docs): remove Scrumbuiss * chore(docs): remove Scrumbuiss logo
`buildLocation` expects an object [docs](https://tanstack.com/router/latest/docs/framework/react/api/router/RouterType#buildlocation-method)
|
@CanRau is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes involve updates to the documentation regarding client-side routing integration with NextUI components. The Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
apps/docs/content/docs/guide/routing.mdx (1)
272-272
: LGTM! Consider adding documentation references.The fix correctly implements
buildLocation
by passing the required object parameter. To help future developers, consider adding:
- A code comment explaining that
buildLocation
expects an object- A link to the TanStack Router documentation for
buildLocation
+ // buildLocation expects an object with `to` property + // See: https://tanstack.com/router/latest/docs/api/router#buildlocation useHref={(to) => router.buildLocation({ to }).href}
buildLocation
expects an object docsSummary by CodeRabbit
New Features
useHref
prop in theNextUIProvider
.useRouter
with Next.js anduseNavigate
with React Router.Documentation
useHref
function.