fix: accordion item focus effect input focus

[chioio]

📝 Description

Fix: input focus error when using in accordion with selected/default expand keys on page loaded.

Mini-reproduction: nextui-input-focus-error

⛳️ Current behavior (updates)

Change input wrapper onClick property, removed condition e.currentTarget === e.target

🚀 New behavior

Input component focus behavior normal in accordion component with selected/default expand keys

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Nothing!

Summary by CodeRabbit

• Bug Fixes

  • Improved click event handling for input components, streamlining focus logic.

• Refactor

  • Simplified internal code structure for clarity and conciseness while maintaining backward compatibility.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 58f5226

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

@chioio is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

The changes in this pull request enhance the useInput hook within the use-input.ts file by simplifying the click event handling for the getInputWrapperProps and getInnerWrapperProps functions. The onClick handlers now directly call focus() on the domRef without checking if the clicked target is the current target. Minor adjustments were also made to props handling and code structure, but the core functionality and API remain unchanged, ensuring backward compatibility.

Changes

File Path	Change Summary
packages/components/input/src/use-input.ts	Enhanced click event handling in getInputWrapperProps and getInnerWrapperProps functions. Simplified onClick logic by removing target checks and directly calling focus() on domRef. Minor adjustments to props handling and code structure without altering existing API.

Possibly related issues

• [BUG] - Accordion component is avoiding focus on inputs  #3478: The changes may address the issue where clicking on an input inside an accordion requires two clicks to focus, as the new handling improves focus behavior.

Possibly related PRs

• fix(input): added hover and focus to input when label placement is outside-left #2958: Modifies the useInput hook in the same file, adding hover and focus behavior, which is directly related to this PR's changes.
• fix(input): ensure clear button is not focusable when disabled #3774: Addresses focus behavior of the clear button when the input is disabled, relevant to the overall focus management discussed in this PR.

Suggested reviewers

• jrgarciadev
• wingkwong

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between dc5b4f3 and 58f5226.

📒 Files selected for processing (1)

• packages/components/input/src/use-input.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/components/input/src/use-input.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[chioio]

Fixed focus, and still error with validator trigger. When page loaded, focus field trigger validator bug execute normal without accordion

With accordion component and default selected key:

Without accordion component: