Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing react-types package added #4264

Merged
merged 3 commits into from
Dec 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gorgeous-mice-think.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@nextui-org/system": patch
---

Fix, mising react-types package added to the system package
2 changes: 1 addition & 1 deletion apps/docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
"@next/env": "14.3.0-canary.43",
"@react-types/calendar": "3.4.10",
"@react-types/datepicker": "3.8.3",
"@react-types/shared": "3.25.0",
"@react-types/shared": "3.26.0",
"@tailwindcss/typography": "^0.5.9",
"@types/canvas-confetti": "^1.4.2",
"@types/marked": "^5.0.0",
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"@commitlint/config-conventional": "^17.2.0",
"@react-bootstrap/babel-preset": "^2.1.0",
"@react-types/link": "3.5.7",
"@react-types/shared": "3.25.0",
"@react-types/shared": "3.26.0",
"@storybook/react": "^8.4.5",
"@swc/core": "^1.3.35",
"@swc/jest": "^0.2.24",
Expand Down
2 changes: 1 addition & 1 deletion packages/components/accordion/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"@react-stately/tree": "3.8.5",
"@react-aria/button": "3.10.1",
"@react-types/accordion": "3.0.0-alpha.24",
"@react-types/shared": "3.25.0"
"@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/theme": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion packages/components/autocomplete/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"@react-aria/visually-hidden": "3.8.17",
"@react-stately/combobox": "3.10.0",
"@react-types/combobox": "3.13.0",
"@react-types/shared": "3.25.0"
"@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/avatar": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion packages/components/breadcrumbs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"@react-aria/breadcrumbs": "3.5.18",
"@react-aria/utils": "3.26.0",
"@react-types/breadcrumbs": "3.7.8",
"@react-types/shared": "3.25.0"
"@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/theme": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion packages/components/button/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"@react-aria/interactions": "3.22.4",
"@react-aria/utils": "3.26.0",
"@react-aria/focus": "3.18.4",
"@react-types/shared": "3.25.0",
"@react-types/shared": "3.26.0",
"@react-types/button": "3.10.0"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/calendar/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"@react-stately/utils": "3.10.4",
"@react-types/calendar": "3.4.10",
"@react-aria/interactions": "3.22.4",
"@react-types/shared": "3.25.0",
"@react-types/shared": "3.26.0",
"scroll-into-view-if-needed": "3.0.10",
"@types/lodash.debounce": "^4.0.7"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/components/card/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"@react-aria/utils": "3.26.0",
"@react-aria/interactions": "3.22.4",
"@react-aria/button": "3.10.1",
"@react-types/shared": "3.25.0"
"@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/theme": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion packages/components/checkbox/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@react-stately/checkbox": "3.6.9",
"@react-stately/toggle": "3.7.8",
"@react-types/checkbox": "3.8.4",
"@react-types/shared": "3.25.0"
"@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/chip": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion packages/components/date-input/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"@react-aria/i18n": "3.12.3",
"@react-stately/datepicker": "3.10.3",
"@react-types/datepicker": "3.8.3",
"@react-types/shared": "3.25.0",
"@react-types/shared": "3.26.0",
"@react-aria/utils": "3.26.0"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/date-picker/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"@react-stately/overlays": "3.6.11",
"@react-stately/utils": "3.10.4",
"@react-types/datepicker": "3.8.3",
"@react-types/shared": "3.25.0"
"@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/radio": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion packages/components/divider/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"@nextui-org/shared-utils": "workspace:*",
"@nextui-org/react-rsc-utils": "workspace:*",
"@nextui-org/system-rsc": "workspace:*",
"@react-types/shared": "3.25.0"
"@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/theme": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion packages/components/dropdown/src/use-dropdown.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const getMenuItem = <T extends object>(props: Partial<MenuProps<T>> | undefined,

if (mergedChildren && mergedChildren.length) {
const item = ((mergedChildren as CollectionElement<T>[]).find((item) => {
if (item.key === key) {
if (item && item.key === key) {
return item;
}
}) || {}) as {props: MenuProps};
Expand Down
2 changes: 1 addition & 1 deletion packages/components/form/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"@nextui-org/system": "workspace:*",
"@nextui-org/theme": "workspace:*",
"@react-aria/utils": "3.26.0",
"@react-types/shared": "3.25.0",
"@react-types/shared": "3.26.0",
"@react-stately/form": "3.0.6",
"@react-types/form": "^3.7.8"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/components/input/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"@react-aria/textfield": "3.14.10",
"@react-aria/utils": "3.26.0",
"@react-stately/utils": "3.10.4",
"@react-types/shared": "3.25.0",
"@react-types/shared": "3.26.0",
"@react-types/textfield": "3.9.7",
"react-textarea-autosize": "^8.5.3"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/components/listbox/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"@react-aria/focus": "3.18.4",
"@react-aria/interactions": "3.22.4",
"@react-types/menu": "3.9.12",
"@react-types/shared": "3.25.0"
"@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/avatar": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion packages/components/menu/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@react-stately/menu": "3.8.3",
"@react-stately/tree": "3.8.5",
"@react-types/menu": "3.9.12",
"@react-types/shared": "3.25.0"
"@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/theme": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion packages/components/radio/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"@react-aria/visually-hidden": "3.8.17",
"@react-stately/radio": "3.10.8",
"@react-types/radio": "3.8.4",
"@react-types/shared": "3.25.0"
"@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/theme": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion packages/components/select/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"@react-aria/interactions": "3.22.4",
"@react-aria/utils": "3.26.0",
"@react-aria/visually-hidden": "3.8.17",
"@react-types/shared": "3.25.0",
"@react-types/shared": "3.26.0",
"@tanstack/react-virtual": "3.10.9"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/switch/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"@react-aria/utils": "3.26.0",
"@react-aria/visually-hidden": "3.8.17",
"@react-stately/toggle": "3.7.8",
"@react-types/shared": "3.25.0"
"@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/theme": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion packages/components/tabs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"@react-aria/tabs": "3.9.7",
"@react-aria/utils": "3.26.0",
"@react-stately/tabs": "3.6.10",
"@react-types/shared": "3.25.0",
"@react-types/shared": "3.26.0",
"@react-types/tabs": "3.3.10",
"scroll-into-view-if-needed": "3.0.10"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/core/system-rsc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"clean-package": "2.2.0"
},
"dependencies": {
"@react-types/shared": "3.25.0",
"@react-types/shared": "3.26.0",
"clsx": "^1.2.1"
},
"clean-package": "../../../clean-package.config.json",
Expand Down
3 changes: 2 additions & 1 deletion packages/core/system/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
"@react-aria/overlays": "3.23.4",
"@react-aria/utils": "3.26.0",
"@react-stately/utils": "3.10.4",
"@react-types/datepicker": "3.8.3"
"@react-types/datepicker": "3.8.3",
"@react-types/shared": "3.26.0"
}
}
2 changes: 1 addition & 1 deletion packages/hooks/use-aria-accordion-item/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"@react-aria/button": "3.10.1",
"@react-aria/focus": "3.18.4",
"@react-stately/tree": "3.8.5",
"@react-types/shared": "3.25.0"
"@react-types/shared": "3.26.0"
},
"peerDependencies": {
"react": ">=18 || >=19.0.0-rc.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/hooks/use-aria-accordion/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"@react-aria/utils": "3.26.0",
"@react-stately/tree": "3.8.5",
"@react-types/accordion": "3.0.0-alpha.24",
"@react-types/shared": "3.25.0"
"@react-types/shared": "3.26.0"
},
"peerDependencies": {
"react": ">=18 || >=19.0.0-rc.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/hooks/use-aria-button/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"@react-aria/interactions": "3.22.4",
"@react-aria/utils": "3.26.0",
"@react-types/button": "3.10.0",
"@react-types/shared": "3.25.0"
"@react-types/shared": "3.26.0"
},
"devDependencies": {
"clean-package": "2.2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/hooks/use-aria-link/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"@react-aria/interactions": "3.22.4",
"@react-aria/utils": "3.26.0",
"@react-types/link": "3.5.8",
"@react-types/shared": "3.25.0"
"@react-types/shared": "3.26.0"
},
"devDependencies": {
"clean-package": "2.2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/hooks/use-aria-menu/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
},
"dependencies": {
"@react-aria/utils": "3.26.0",
"@react-types/shared": "3.25.0",
"@react-types/shared": "3.26.0",
"@react-aria/menu": "3.15.5",
"@react-aria/interactions": "3.22.4",
"@react-stately/tree": "3.8.5",
Expand Down
2 changes: 1 addition & 1 deletion packages/hooks/use-aria-modal-overlay/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"@react-aria/overlays": "3.23.4",
"@react-aria/utils": "3.26.0",
"@react-stately/overlays": "3.6.11",
"@react-types/shared": "3.25.0"
"@react-types/shared": "3.26.0"
},
"peerDependencies": {
"react": ">=18 || >=19.0.0-rc.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/hooks/use-aria-multiselect/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"@react-types/button": "3.10.0",
"@react-types/overlays": "3.8.10",
"@react-types/select": "3.9.7",
"@react-types/shared": "3.25.0"
"@react-types/shared": "3.26.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Update @react-aria dependencies to their latest compatible versions

The current package dependencies are slightly outdated compared to the latest available versions:

  • @react-aria/i18n: 3.12.3 → 3.12.4
  • @react-aria/interactions: 3.22.4 → 3.22.5
  • @react-aria/label: 3.7.12 → 3.7.13
  • @react-aria/listbox: 3.13.5 → 3.13.6
  • @react-aria/menu: 3.15.5 → 3.16.0
  • @react-aria/selection: 3.20.1 → 3.21.0
  • @react-aria/utils: 3.26.0 (already at latest)

Consider updating these dependencies to their latest versions for better compatibility and to receive the latest bug fixes.

🔗 Analysis chain

Consider aligning all @react-aria/ package versions*

While the update to @react-types/shared 3.26.0 is good, consider aligning the versions of other @react-aria/* packages for better compatibility:

  • @react-aria/i18n: 3.12.3
  • @react-aria/interactions: 3.22.4
  • @react-aria/label: 3.7.12
  • @react-aria/listbox: 3.13.5
  • @react-aria/menu: 3.15.5
  • @react-aria/selection: 3.20.1
  • @react-aria/utils: 3.26.0

Let me generate additional scripts to check the actual dependencies in the package.json file to compare with the latest versions.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check latest versions of react-aria packages
for pkg in i18n interactions label listbox menu selection utils; do
  echo "@react-aria/$pkg:"
  curl -s "https://registry.npmjs.org/@react-aria/$pkg" | jq -r '."dist-tags".latest'
done

Length of output: 1453


Script:

#!/bin/bash
# Check the actual dependencies in package.json
cat packages/hooks/use-aria-multiselect/package.json | jq -r '.dependencies | to_entries | .[] | select(.key | startswith("@react-aria/")) | "\(.key): \(.value)"'

Length of output: 357

},
"peerDependencies": {
"react": ">=18 || >=19.0.0-rc.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/hooks/use-aria-toggle-button/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"@react-aria/utils": "3.26.0",
"@react-stately/toggle": "3.7.8",
"@react-types/button": "3.10.0",
"@react-types/shared": "3.25.0"
"@react-types/shared": "3.26.0"
},
"devDependencies": {
"clean-package": "2.2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/hooks/use-intersection-observer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"dependencies": {
"@react-aria/utils": "3.26.0",
"@react-aria/ssr": "3.9.6",
"@react-types/shared": "3.25.0",
"@react-types/shared": "3.26.0",
"@react-aria/interactions": "3.22.4"
},
"peerDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/utilities/aria-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"@react-stately/collections": "3.11.0",
"@react-stately/overlays": "3.6.11",
"@react-types/overlays": "3.8.10",
"@react-types/shared": "3.25.0"
"@react-types/shared": "3.26.0"
},
"devDependencies": {
"clean-package": "2.2.0",
Expand Down
Loading
Loading