fix: treat undefined as false for boolean variants

nextui-org · Jan 14, 2024 · 18a1a33 · 18a1a33
1 parent ed21cdd
commit 18a1a33
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/__tests__/tv.test.ts b/src/__tests__/tv.test.ts
@@ -314,6 +314,22 @@ describe("Tailwind Variants (TV) - Default", () => {
 
     expect(h1({color: "green", isUnderline: false})).toBe(expectedResult);
   });
+
+  test("should treat undefined and false identically for boolean variants", () => {
+    const h1 = tv({
+      base: "text-3xl",
+      variants: {
+        bool: {
+          true: "underline",
+          false: "no-underline",
+        },
+      },
+    });
+
+    expect(h1({bool: true})).toBe("text-3xl underline");
+    expect(h1({bool: false})).toBe("text-3xl no-underline");
+    expect(h1()).toBe("text-3xl no-underline");
+  });
 });
 
 describe("Tailwind Variants (TV) - Slots", () => {

diff --git a/src/index.js b/src/index.js
@@ -199,7 +199,10 @@ export const tv = (options, configProp) => {
         }
       }
 
-      const value = variantObj[variantKey] || variantObj[falsyToString(defaultVariantProp)];
+      const value =
+        variantObj[variantKey] ||
+        variantObj[falsyToString(defaultVariantProp)] ||
+        variantObj["false"];
 
       if (
         typeof screenValues === "object" &&