Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust path for types #164

Merged
merged 1 commit into from
Feb 24, 2024
Merged

fix: adjust path for types #164

merged 1 commit into from
Feb 24, 2024

Conversation

Gomah
Copy link
Contributor

@Gomah Gomah commented Feb 23, 2024

Description

Adjusted the exports types target

Additional context

For projects with moduleResolution set to NodeNext, exports has priority over types in package.json, as the current types target in exports is incorrect, it's currently throwing an error:

Screenshot 2024-02-24 at 8 04 00 am

What is the purpose of this pull request?

  • Bug fix

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the Style Guide.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

Copy link
Collaborator

@mskelton mskelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mskelton mskelton merged commit 78ccdb9 into nextui-org:main Feb 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants