Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support multi-level extend for compoundVariants #170

Merged
merged 2 commits into from
Mar 15, 2024
Merged

fix: support multi-level extend for compoundVariants #170

merged 2 commits into from
Mar 15, 2024

Conversation

mskelton
Copy link
Collaborator

Fixes #168

@mskelton mskelton mentioned this pull request Mar 13, 2024
Closed
@benjamincanac
Copy link

Thanks for the reactivity! Just to let you know, I believe this also happens with compoundSlots. I can provide a reproduction if needed.

jrgarciadev
jrgarciadev approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @mskelton 🙏🏻

@jrgarciadev jrgarciadev merged commit 8ec5f34 into main Mar 15, 2024
4 checks passed
@jrgarciadev jrgarciadev deleted the fix-compound-variant-extend branch March 15, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrgarciadev jrgarciadev jrgarciadev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compound variants are lost when extending multiple times
3 participants
@mskelton @benjamincanac @jrgarciadev