rsx_i should be computed based on x_i, but not x'_i #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hjlpb is attempting to deploy a commit to the Nexus Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
Discussed in #199 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yoichi-nexus
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
This looks good. For all indices except i, the original register values are kept in rsx_i, which get used as final values later.
The original equation also happened to be true on vm executions (because for those registers, the new value and the old value are the same), but that's more like an accident.
|
Thank you very much for the find and the fix @hjlpb ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.