-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: oauth2 redirect url not consistent #930
Merged
Merged
+235
−175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naiba
reviewed
Dec 31, 2024
path一致还是完全一致,能传不同query吗
…On Tue, Dec 31, 2024 at 17:46 UUBulb ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In cmd/dashboard/controller/oauth2.go
<#930 (comment)>:
> @@ -91,7 +91,7 @@ func exchangeOpenId(c *gin.Context, o2confRaw *model.Oauth2Config, provider stri
return "", singleton.Localizer.ErrorT("invalid state key")
}
- o2conf := o2confRaw.Setup(getRedirectURL(c, provider, rTypeLogin))
+ o2conf := o2confRaw.Setup(getRedirectURL(c, provider, typ))
cf access 是要求 authorization redirect uri 和申请 token 的 redirect uri 一致
—
Reply to this email directly, view it on GitHub
<#930 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG7DUMIJ7PE2OFLB3AR26332IJRYJAVCNFSM6AAAAABUMOYT4CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRWGMZDGNBQGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
不行 provider query 必须带上 |
加query也不行的吗,那只能加cookie了呀
…On Tue, Dec 31, 2024 at 17:50 UUBulb ***@***.***> wrote:
path一致还是完全一致,能传不同query吗
不行 provider query 必须带上
好像只有github才是前缀匹配
—
Reply to this email directly, view it on GitHub
<#930 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG7DUMOT3BIWQAQEQ6EDYST2IJSH5AVCNFSM6AAAAABUMOYT4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRWGI4TOMJTGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
cache的state加个行为,对应行为操作 |
你直接改下?应该只是改下api,前端删些东西就好 |
url只用一个吗 |
是的 那个cachekey的value加个action得了,绑定就绑定,不绑定就登录,前端相关逻辑和接口删除
…On Tue, Dec 31, 2024 at 18:05 UUBulb ***@***.***> wrote:
cache的state加个行为,对应行为操作
url只用一个吗
—
Reply to this email directly, view it on GitHub
<#930 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG7DUMOC5NR7G6BD2C6DCLL2IJT7HAVCNFSM6AAAAABUMOYT4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRWGMYDOOBYHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
直接跳转过去
…On Tue, Dec 31, 2024 at 18:41 William Liu ***@***.***> wrote:
是的 那个cachekey的value加个action得了,绑定就绑定,不绑定就登录,前端相关逻辑和接口删除
On Tue, Dec 31, 2024 at 18:05 UUBulb ***@***.***> wrote:
> cache的state加个行为,对应行为操作
>
> url只用一个吗
>
> —
> Reply to this email directly, view it on GitHub
> <#930 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AG7DUMOC5NR7G6BD2C6DCLL2IJT7HAVCNFSM6AAAAABUMOYT4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRWGMYDOOBYHA>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #928