Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.2.0 #358

Merged
merged 132 commits into from
Dec 11, 2024
Merged

Release 4.2.0 #358

merged 132 commits into from
Dec 11, 2024

Conversation

ggabernet
Copy link
Member

  • Adds TRUST4 support
  • Adds options to remove V and C primer region by length when primer sequences are unknown.
  • Adds option to save non-productive sequences after IgBlast alignment.
  • Updated nf-core template to v3.0.2
  • Deprecated isotype_column param in favor of annotating C region or C primer information in the c_call column when c_call is NA.
  • Avoids saving pRESTO intermediate files in results directory to save space.
  • Simplified pRESTO Maskprimers score and Maskprimers extract processes.
  • Fix clustersets approach, consider both reads clusters annotation.
  • Allow for partial alignments in MakeDB for mouse TCR data, to bypass junction check for TRAV germlines with additional positions (e.g. 84A).
  • Fix parse logs merging dataframes using pandas join to produce logs even when there are failing samples.
  • Use pRESTO Collapseseq with n=0 by default to improve runtime.

@ggabernet ggabernet requested review from mapo9 and ssnn-airr November 26, 2024 14:59
Copy link

github-actions bot commented Nov 26, 2024

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit 91449a8

+| ✅ 300 tests passed       |+
#| ❔   8 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-12-10 21:00:41

Copy link
Collaborator

@mapo9 mapo9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀

- [Friederike Hanssen](https://github.com/ggabernet/friederikehanssen)
- [Friederike Hanssen](https://github.com/friederikehanssen)
- [Simon Heumos](https://github.com/subwaystation)
- [Mark Polster](https://github.com/mapo9)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for that :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course, I thought you were already there

@ggabernet
Copy link
Member Author

Do not merge yet, as TRUST4 should be added to the pipeline diagram!

.nf-core.yml Show resolved Hide resolved
Copy link
Contributor

@ssnn-airr ssnn-airr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mapo9 mapo9 closed this Nov 28, 2024
@mapo9 mapo9 reopened this Nov 28, 2024
@mapo9
Copy link
Collaborator

mapo9 commented Nov 28, 2024

Do not merge yet, as TRUST4 should be added to the pipeline diagram!

I can make a metromap where I remove MiXCR and have only TRUST4 later today

@mapo9
Copy link
Collaborator

mapo9 commented Nov 28, 2024

@ggabernet I added the metromap directly to this pr. Please check it out

@ggabernet ggabernet merged commit d91dd84 into master Dec 11, 2024
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants