-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allocate more RAM to the process running MACS2 #48
Conversation
Dev > Master for v1.0.0 release
Add Zenodo doi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 👍 Can you update CHANGELOG
too please. Thanks.
Would you mind also adding a separate PR (or you can do it here if you like) increasing the resource requirements for all of the |
Added in BED download functionality from AWS iGenomes in the PR below along with some other minor changes: |
Hi @drpatelh, sorry I couldn't reply back to you asap since I wasn't at home yesterday. I will take a look at your review and work on the code later today. |
Hi @jinmingda . No worries! Ive incorporated all the changes you suggested now. Can you check the open PR to see ive missed anything please and I'll add it in 👍 Thanks again. |
@drpatelh I think your PR has incorporated everything I've found. However, it seems the description of using the staged blacklist file in makeGenomeFilter is not included in the CHANGELOG. |
Good point. I'll add it in tomorrow. Thanks. |
If there are any other improvements that you think that the pipeline would benefit from then let me know and I'll try and add them in. Probably going to do a minor release over the next couple of weeks to get the pipeline running on AWS without issue. |
@drpatelh Sure! I will keep you informed if I find any bugs or things that can improve the pipeline. |
Many thanks to contributing to nf-core/atacseq!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker
).nf-core lint .
).docs
is updatedCHANGELOG.md
is updatedREADME.md
is updatedLearn more about contributing: https://github.com/nf-core/atacseq/tree/master/.github/CONTRIBUTING.md
Description
The memory footprint of macs2 is largely based on the size of the input BAM file. The label
process_long
used in "merge_library_macs" and "merge_replicate_macs" can only assign 2GB to the processes, which is hardly enough for many real human samples.