Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bowtie2 as choice for aligner #160

Closed
ivokwee opened this issue Jun 9, 2020 · 4 comments
Closed

Add bowtie2 as choice for aligner #160

ivokwee opened this issue Jun 9, 2020 · 4 comments
Assignees
Labels
DSL2 v2.0 feature-request Request to add new functionality
Milestone

Comments

@ivokwee
Copy link

ivokwee commented Jun 9, 2020

Hi. I succesfully tried bowtie2 as aligner by installing bowtie2 in the docker image, then replacing the aligner code in main.nf with the code below. Everything seems to work fine but of course all results are in the results/bwa folder. I wonder if it would be nice to let the user choose between BWA-mem, or Bowtie2. Ivo

"""
bowtie2 \\
   -p $task.cpus \\
   -x ${index}/${bwa_base} \\
   -U $reads \\
   | samtools view -@ $task.cpus -b -h -F 0x0100 -O BAM -o ${prefix}.bam -
"""
@drpatelh
Copy link
Member

drpatelh commented Jun 9, 2020

Thanks @ivokwee. I was planning on adding in such options when this pipeline is eventually ported to DSL 2. Im a bit confused as to how the pipeline worked with the command you sent though because that implies that bowtie2 worked with a bwa index? The pipeline would need to be changed in a few places to cater for multiple aligners.

bowtie2 \\
   -p $task.cpus \\
   -x ${index}/${bwa_base} \\

@drpatelh
Copy link
Member

drpatelh commented Jun 9, 2020

From the benchmarking I have seen to date it appears that bwa and bowtie2 give incredibly similar results. I realise it's personal preference and mine has always been bwa but I am wondering whether it makes more sense to add other alignment options instead e.g. STAR for speed.

@drpatelh drpatelh added the feature-request Request to add new functionality label Jun 9, 2020
@ivokwee
Copy link
Author

ivokwee commented Jun 9, 2020 via email

@JoseEspinosa JoseEspinosa added this to the 2.0 milestone Sep 23, 2021
@JoseEspinosa
Copy link
Member

As suggested by @drpatelh in #233, the DSL2 implementation of the pipeline could have a sub-workflow that implements bowtie2 as an aligner, see here the current bwa_men implementation as a template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DSL2 v2.0 feature-request Request to add new functionality
Projects
None yet
Development

No branches or pull requests

3 participants