Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0 #66

Open
wants to merge 625 commits into
base: master
Choose a base branch
from
Open

v1.0.0 #66

wants to merge 625 commits into from

Conversation

BarryDigby
Copy link
Collaborator

DSL2 version of nf-core/circrna.

A few minor comments on the linting warnings:

  1. I need some assistance configuring the full AWS test dataset. The data can be accessed via SRA, this should be straightforward using fetchngs.

  2. Links to manuscripts / DOI links - I have a paper for the workflow currently under review, I'm hoping this will be accepted soon having addressed reviewer comments.

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@maxulysse
Copy link
Member

I feel like comments from #69 haven't been integrated in this PR yet.

Copy link

github-actions bot commented Feb 2, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 98923dd

+| ✅ 216 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-06-19 19:30:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

8 participants