Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix volcano plot legend #213

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Fix volcano plot legend #213

merged 2 commits into from
Dec 5, 2023

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Dec 4, 2023

Apply the correct log2 transform to FC threshold when used in the volcano plot

Closes #212

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@pinin4fjords pinin4fjords linked an issue Dec 4, 2023 that may be closed by this pull request
Copy link

github-actions bot commented Dec 5, 2023

nf-core lint overall result: Passed ✅

Posted for pipeline commit e4bfbf9

+| ✅ 160 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-12-05 09:15:51

@pinin4fjords pinin4fjords merged commit b789237 into dev Dec 5, 2023
14 checks passed
@pinin4fjords pinin4fjords deleted the fix_volcano_legend branch December 5, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Final report, volcano plot: points wrongly marked red
2 participants