Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round numeric report tables #222

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Round numeric report tables #222

merged 3 commits into from
Jan 11, 2024

Conversation

WackerO
Copy link
Collaborator

@WackerO WackerO commented Jan 9, 2024 •
edited
Loading

This adds some more round_dataframe_columns to the report

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@WackerO WackerO changed the base branch from master to dev January 9, 2024 10:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @WackerO,

It looks like this pull-request is has been made against the WackerO/differentialabundance master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the WackerO/differentialabundance dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 2e9560d

+| ✅ 164 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-11 07:36:01

@WackerO WackerO changed the base branch from dev to master January 9, 2024 11:48
@WackerO WackerO changed the base branch from master to dev January 9, 2024 11:48
pinin4fjords
pinin4fjords reviewed Jan 10, 2024
View reviewed changes
Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks uncontroversial- but you forgot the CHANGELOG

pinin4fjords
pinin4fjords approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WackerO WackerO merged commit 3ce6e97 into nf-core:dev Jan 11, 2024
14 checks passed
@WackerO WackerO deleted the round_report branch January 11, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinin4fjords pinin4fjords pinin4fjords approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WackerO @pinin4fjords