-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention missing dots in report volcano #232
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assume the GSEA changes here are because we need to merge in master.
Actually. what I was thinking with the warning is to actually check the data for values of 0 in the p values, and conditionally display a prominent warning under the plot:
"x features with p values of 0 are not shown- please refer to the results tables"
Ah, those are in this PR because I created volcano_round from dev after adding the GSEA update. Can also do that. |
How about this? @pinin4fjords |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks Oskar. Tiny question about default behaviour, but I'll leave you to resolve that (or not) before you merge.
…into volcano_round
…into volcano_round
Instead of #229
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).