Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split up config files to be more modular #186

Merged
merged 4 commits into from
Aug 24, 2023
Merged

split up config files to be more modular #186

merged 4 commits into from
Aug 24, 2023

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/fetchngs branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

adamrtalbot
adamrtalbot reviewed Aug 23, 2023
View reviewed changes
nextflow.config Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 23, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 011addc

+| ✅ 134 tests passed       |+
#| ❔  13 tests were ignored |#
!| ❗   7 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • files_exist - File not found: lib/WorkflowFetchngs.groovy
  • nextflow_config - Config manifest.version should end in dev: 1.10.1
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
  • schema_description - No description provided in schema for parameter: dbgap_key

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-08-24 13:53:30

adamrtalbot
adamrtalbot approved these changes Aug 24, 2023
View reviewed changes
nextflow.config Outdated Show resolved Hide resolved
maxulysse and others added 2 commits August 24, 2023 15:50
@maxulysse @adamrtalbot
Update nextflow.config
82fa500 
Co-authored-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
@maxulysse
remove if statement
011addc
@maxulysse maxulysse merged commit addfa36 into nf-core:refactor Aug 24, 2023
4 checks passed
@maxulysse maxulysse deleted the split_configs branch January 9, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrtalbot adamrtalbot adamrtalbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @adamrtalbot