Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom assembly options and export assembly QC #149

Merged
merged 6 commits into from
Feb 2, 2021

Conversation

d4straub
Copy link
Collaborator

@d4straub d4straub commented Feb 1, 2021

  • added exit code 247 to bowtie2 retry, 247 is when it runs out of memory while index building
  • added two parameters (--spades_options & --megahit_options) to allow custom SPAdes and MEGAHIT options, this is required to adjust e.g. k-mers or presets for more challenging assemblies
  • export bowtie2 mapping statistics as another important QC. This is nicely integrated into the MultiQC report when assembling individual samples but not when assembling groups. Because it is here impossible to match assembly to sample and would create a huge mess.
  • docs are updated

edit: Just figured out that MEGAHIT told Process megahit (groupall) terminated with an error exit status (250) when running into RAM issues. That should be added as well. Unfortunately, time limits resulted in an empty error code, very unfortunate.
edit2: Re-try MEGAHIT when exiting with code 250

@d4straub d4straub requested a review from skrakau February 1, 2021 16:35
CHANGELOG.md Outdated Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
Co-authored-by: Sabrina Krakau <sabrinakrakau@gmail.com>
main.nf Outdated Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
main.nf Show resolved Hide resolved
main.nf Show resolved Hide resolved
main.nf Show resolved Hide resolved
@skrakau
Copy link
Member

skrakau commented Feb 2, 2021

Regarding the time limit and the missing exit code, can it be a Nextflow or slurm problem if this is not reported properly? See e.g. nextflow-io/nextflow#1354

Didn't it work in the past?

@skrakau
Copy link
Member

skrakau commented Feb 2, 2021

Still, I think in general this way of allowing general custom options as strings is not ideal, we should fix those as soon as possible.

@d4straub
Copy link
Collaborator Author

d4straub commented Feb 2, 2021

Regarding the time limit and the missing exit code, can it be a Nextflow or slurm problem if this is not reported properly? See e.g. nextflow-io/nextflow#1354
Didn't it work in the past?

edit: Sorry, was too fast here, sure that might be. Sometimes it works for me, sometimes it doesnt.

Still, I think in general this way of allowing general custom options as strings is not ideal, we should fix those as soon as possible.

True, but I am not certain at this point which options might be most helpful.

@d4straub d4straub merged commit 31c786b into nf-core:dev Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants