Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix publishing of BUSCO downloads #309

Merged
merged 2 commits into from
May 31, 2022
Merged

Fix publishing of BUSCO downloads #309

merged 2 commits into from
May 31, 2022

Conversation

skrakau
Copy link
Member

@skrakau skrakau commented May 30, 2022 •
edited
Loading

Publish BUSCO busco_downloads/ folder only via dedicated BUSCO_SAVE_DOWNLOADS process, not from actual BUSCO process to avoid overwriting in results directory from multiple processes and to prevent warning.

Changed to use pattern: "..."to specify what exactly should be published.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented May 30, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit f4d30e2

+| ✅ 147 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-05-30 19:49:06

@skrakau skrakau force-pushed the fix_busco_downloads_publishing branch from 5c0c2a0 to f4d30e2 Compare May 30, 2022 19:48
@skrakau skrakau requested a review from d4straub May 31, 2022 08:11
@jfy133
Copy link
Member

jfy133 commented May 31, 2022

LGTM

@skrakau skrakau merged commit 5f85160 into nf-core:dev May 31, 2022
@skrakau skrakau deleted the fix_busco_downloads_publishing branch July 22, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

@d4straub d4straub Awaiting requested review from d4straub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skrakau @jfy133