Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate institutional configs #319

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Activate institutional configs #319

merged 2 commits into from
Jun 3, 2022

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jun 3, 2022

PR checklist

This activates pipeline-specific institutional nf-core/configs, to allow customisation of pipeline resources on a pipeline-tuned per-cluster basis.

An EVA specific config for mag has been created on nf-core/configs nf-core/configs#380

To close #318

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 17c496c

+| ✅ 146 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '2.2.0'
  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-06-03 11:08:35

@jfy133 jfy133 requested review from d4straub and skrakau June 3, 2022 11:37
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@skrakau skrakau merged commit 4dea198 into nf-core:dev Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants