Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AncientDNA results files overwriting #451

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Fix AncientDNA results files overwriting #451

merged 1 commit into from
Jun 7, 2023

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jun 5, 2023

resolves #450

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 requested review from maxibor and alexhbnr June 5, 2023 08:42
@github-actions
Copy link

github-actions bot commented Jun 5, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 885c4be

+| ✅ 158 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-06-05 08:45:18

@jfy133 jfy133 linked an issue Jun 5, 2023 that may be closed by this pull request
The ancient DNA sub-workflow ignores the assembler in the filenames and overwrites files #450
Closed
JoseEspinosa
JoseEspinosa approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎸

@jfy133 jfy133 merged commit 3cfcc21 into nf-core:dev Jun 7, 2023
@jfy133 jfy133 deleted the ancient-dna-naming branch June 7, 2023 10:20
@maxibor maxibor mentioned this pull request Jun 19, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

@maxibor maxibor Awaiting requested review from maxibor

@alexhbnr alexhbnr Awaiting requested review from alexhbnr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The ancient DNA sub-workflow ignores the assembler in the filenames and overwrites files
2 participants
@jfy133 @JoseEspinosa