Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing input when --keep_phix is specified #50

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

skrakau
Copy link
Member

@skrakau skrakau commented Jun 2, 2020

When --keep_phix is specified, reads were not redirected to channels trimmed_reads_kraken2 and trimmed_reads_bowtie2, which causes errors (when the downstream processes using them are not explicitly turned off). Fixed that.

In case that was on purpose and the parameter --keep_phix should only be used with certain parameter combinations, this should be caught before.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/mag/tree/master/.github/CONTRIBUTING.md

@skrakau skrakau changed the title Fixed missing input when --keep_phix is specified Fixed missing input when --keep_phix is specified Jun 2, 2020
Copy link
Member

@HadrienG HadrienG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@skrakau skrakau merged commit e7d0621 into nf-core:dev Jun 3, 2020
@d4straub
Copy link
Collaborator

d4straub commented Jun 3, 2020

Hmhm changelog? ;)

@skrakau skrakau mentioned this pull request Jun 4, 2020
@skrakau skrakau deleted the fix_missing_input branch November 4, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants