Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix malformed input to MEGAHIT with non-run-merged SEdata #558

Merged
merged 11 commits into from
Jan 26, 2024
Merged

Fix malformed input to MEGAHIT with non-run-merged SEdata #558

merged 11 commits into from
Jan 26, 2024

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jan 16, 2024 •
edited
Loading

Closes #557

Also remove some extra dumps discovered during testing

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 marked this pull request as draft January 16, 2024 05:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit ff0c4aa

+| ✅ 161 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file [TODO: try and test using for --host_fasta and --host_genome]
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowMag.groovy: Optionally add in-text citation tools to this list.
  • schema_lint - Input mimetype is missing or empty

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-19 13:46:19

@jfy133 jfy133 marked this pull request as ready for review January 16, 2024 08:22
jfy133
jfy133 commented Jan 16, 2024
View reviewed changes
workflows/mag.nf Outdated Show resolved Hide resolved
jfy133
jfy133 commented Jan 16, 2024
View reviewed changes
workflows/mag.nf Outdated Show resolved Hide resolved
jfy133
jfy133 commented Jan 16, 2024
View reviewed changes
workflows/mag.nf Outdated Show resolved Hide resolved
jfy133
jfy133 commented Jan 16, 2024
View reviewed changes
workflows/mag.nf Outdated Show resolved Hide resolved
@jfy133
Copy link
Member Author

jfy133 commented Jan 19, 2024

@nf-core-bot fix linting

CarsonJM
CarsonJM approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@CarsonJM CarsonJM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jfy133 jfy133 merged commit eb97cbd into dev Jan 26, 2024
15 checks passed
@jfy133 jfy133 deleted the fix-cat-se-data-dev branch February 5, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarsonJM CarsonJM CarsonJM approved these changes

@maxibor maxibor Awaiting requested review from maxibor

@d4straub d4straub Awaiting requested review from d4straub

@HadrienG HadrienG Awaiting requested review from HadrienG

@prototaxites prototaxites Awaiting requested review from prototaxites

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfy133 @CarsonJM @nf-core-bot