Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move custom validation to groovy #25

Open
RobJY opened this issue Mar 19, 2024 · 4 comments
Open

move custom validation to groovy #25

RobJY opened this issue Mar 19, 2024 · 4 comments
Assignees
Labels
enhancement Improvement for existing functionality

Comments

@RobJY
Copy link
Contributor

RobJY commented Mar 19, 2024

Description of feature

move bin/check_marker_sheet.py and bin/check_sample_and_marker_sheet.py to groovy

@RobJY RobJY added the enhancement Improvement for existing functionality label Mar 19, 2024
@RobJY RobJY self-assigned this Mar 19, 2024
@josenimo
Copy link

Hey Rob, by moving it to groovy, what do you mean?
I assume it means converting the local modules into fully fledged nf-core modules?

@RobJY
Copy link
Contributor Author

RobJY commented Mar 20, 2024

Yes, that's correct

@jmuhlich
Copy link
Member

Not converting to full nf-core modules, but rather converting from python scripts that run as separate (local) modules in the workflow into .nf scripts that run as part of the workflow itself (see subworkflows/local/utils_nfcore_mcmicro_pipeline/main.nf).

@RobJY
Copy link
Contributor Author

RobJY commented Apr 26, 2024

I have updated code for this in my fork in branch 'input_validation'. I'll make a PR once #29 has been merged.
It still needs a little work. I'm unsure about how to proceed in a few places, so we can discuss that and any changes you'd like in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants