Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MultiQC to v1.13a (dev) #1814

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Bump MultiQC to v1.13a (dev) #1814

merged 4 commits into from
Jun 29, 2022

Conversation

apeltzer
Copy link
Member

This bumps MultiQC to v1.13a, the dev version of MultiQC that should fix issues for smrnaseq and also some other pipelines where DupRadar (I think rnaseq? @drpatelh FYI) was used and the HTML report contained duplicated sections.

Can be used until there is a new proper V1.13 release as @ewels suggested 🥳

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the container has an issue and thus the test errors:

$ docker run -it quay.io/biocontainers/multiqc:1.13a--pyhdfd78af_0
# multiqc
Traceback (most recent call last):
  File "/usr/local/bin/multiqc", line 10, in <module>
    sys.exit(multiqc())
TypeError: 'module' object is not callable

@ewels
Copy link
Member

ewels commented Jun 28, 2022

Oh dear. Did your Conda release break MultiQC for everyone @apeltzer? 😱

@apeltzer
Copy link
Member Author

I will fix this now, after baby sleeps. No idea what is the problem there but can overwrite build number after bugfixing ...

@apeltzer
Copy link
Member Author

Ok, just opened new PR on bioconda and will try debugging locally whats going on there. Its odd but as far as I can see the only thing that I had to add was new url + sha256 sum + rich-click as dependency and nothing else ...?

@ewels
Copy link
Member

ewels commented Jun 28, 2022

Yeah I'm a bit worried that this is something bigger / upstream.. It smells like a Python name spacing issue.

@apeltzer
Copy link
Member Author

bioconda/bioconda-recipes#35553 fixes this, will wait until recipes are there, then fix it and update this PR to get it to modules again - thanks for the help @ewels !

@apeltzer apeltzer requested a review from JoseEspinosa June 28, 2022 19:09
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @apeltzer! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants