-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump MultiQC to v1.13a (dev) #1814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the container has an issue and thus the test errors:
$ docker run -it quay.io/biocontainers/multiqc:1.13a--pyhdfd78af_0
# multiqc
Traceback (most recent call last):
File "/usr/local/bin/multiqc", line 10, in <module>
sys.exit(multiqc())
TypeError: 'module' object is not callable
Oh dear. Did your Conda release break MultiQC for everyone @apeltzer? 😱 |
I will fix this now, after baby sleeps. No idea what is the problem there but can overwrite build number after bugfixing ... |
Ok, just opened new PR on bioconda and will try debugging locally whats going on there. Its odd but as far as I can see the only thing that I had to add was new url + sha256 sum + rich-click as dependency and nothing else ...? |
Yeah I'm a bit worried that this is something bigger / upstream.. It smells like a Python name spacing issue. |
bioconda/bioconda-recipes#35553 fixes this, will wait until recipes are there, then fix it and update this PR to get it to modules again - thanks for the help @ewels ! |
Predicted new container names ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @apeltzer! 🚀
This bumps MultiQC to v1.13a, the dev version of MultiQC that should fix issues for smrnaseq and also some other pipelines where DupRadar (I think rnaseq? @drpatelh FYI) was used and the HTML report contained duplicated sections.
Can be used until there is a new proper V1.13 release as @ewels suggested 🥳
PR checklist
Closes #XXX
versions.yml
file.label
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware