Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quay.io #3496

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Remove quay.io #3496

merged 1 commit into from
Jun 7, 2023

Conversation

maxulysse
Copy link
Member

cf #3424

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♀️

@maxulysse
Copy link
Member Author

Failure with conda tests, as usual, I'm tempted to either merge as is, or remove conda for these tests

@maxulysse
Copy link
Member Author

Merging with the failed conda md5sum. We need to think how to properly fix that

@maxulysse maxulysse merged commit 591b716 into master Jun 7, 2023
@maxulysse maxulysse deleted the maxulysse-patch-2 branch June 7, 2023 16:04
buehlere pushed a commit to mskcc-omics-workflows/modules-fork that referenced this pull request Jul 13, 2023
buehlere pushed a commit to mskcc-omics-workflows/modules-fork that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants