Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kallisto quant tidy up #4334

Merged
merged 14 commits into from
Nov 15, 2023
Merged

Kallisto quant tidy up #4334

merged 14 commits into from
Nov 15, 2023

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Nov 14, 2023

In this PR:

  • All outputs moved into prefixed directory, for neater arrangement of published files
  • Allow for strandedness param to have been provided via ext.args, in which case we don't infer these from the meta.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@pinin4fjords
Copy link
Member Author

@nf-core-bot fix linting

Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@drpatelh drpatelh added this pull request to the merge queue Nov 15, 2023
Merged via the queue into master with commit bdc2a97 Nov 15, 2023
11 checks passed
@drpatelh drpatelh deleted the kallisto_updates branch November 15, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants