Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation issue when using panel_file instead of panel #101

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Fix validation issue when using panel_file instead of panel #101

merged 1 commit into from
Jun 28, 2024

Conversation

fbdtemme
Copy link
Collaborator

A map access error occurs because the meta map gets overwritten with null in validate_panel when no panel key is present. We need to return the meta map unmodified instead.

@fbdtemme fbdtemme requested a review from ambarrio June 27, 2024 10:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 27, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit dd34553

+| ✅ 202 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-06-27 10:27:22

@fbdtemme
Fix validation issue when using panel_file instead of panel
dd34553 
A map access error occurs because the meta map gets overwritten with null in validate_panel when no panel key is present. We need to return the meta map unmodified instead.
ambarrio
ambarrio approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@ambarrio ambarrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbdtemme fbdtemme merged commit dbaec78 into nf-core:dev Jun 28, 2024
4 checks passed
@fbdtemme fbdtemme deleted the fix-panel-file branch July 5, 2024 13:37
@fbdtemme fbdtemme mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambarrio ambarrio ambarrio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbdtemme @ambarrio