Release 1.0.1 - Minor template update release #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Important! Template update for nf-core/tools v2.13.1
Added option for using draft genomes with insilicoseq
modified changelog for minor release and bumped version number
11 tasks
Fixing the failing tests in Release 1.0.1
…ma separated list of groups
mashehu
approved these changes
Apr 15, 2024
Comment on lines
14
to
15
| run: | | ||
| curl -s https://nf-co.re/pipelines.json | jq -r '.remote_workflows[] | select(.full_name == "${{ github.repository }}") | .topics[]' | awk '{print "#"$0}' | tr '\n' ' ' >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Suggested change
| run: | | |
| curl -s https://nf-co.re/pipelines.json | jq -r '.remote_workflows[] | select(.full_name == "${{ github.repository }}") | .topics[]' | awk '{print "#"$0}' | tr '\n' ' ' >> $GITHUB_OUTPUT | |
| run: | | |
| echo "topics=$(curl -s https://nf-co.re/pipelines.json | jq -r '.remote_workflows[] | select(.full_name == "${{ github.repository }}") | .topics[]' | awk '{print "#"$0}' | tr '\n' ' ')" >> $GITHUB_OUTPUT |
A small oversight in the last template release, this is from the current dev branch, to make this action actually work
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
added pattern to ncbidownload_group to allow a comma separated list of groups
SPPearce
approved these changes
Apr 23, 2024
main.nf
Outdated
| // Validate input parameters | ||
| if (params.validate_params) { | ||
| validateParameters() | ||
| // TODO nf-core: Remove this line if you don't need a FASTA file |
There was a problem hiding this comment.
Should note that multiqc version has changed 1.19 -> 1.21
CHANGELOG.md
Outdated
| @@ -3,7 +3,20 @@ | |||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## v1.0.0 - 2024-02-07 | |||
| ## 1.0.1 - 2024-03-22 | |||
There was a problem hiding this comment.
Suggested change
| ## 1.0.1 - 2024-03-22 | |
| ## 1.0.1 - 2024-03-23 |
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
Changes based on PR #41 reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).