Dev -> master for v1.0.0 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialise testing and base template functionality
maxulysse
reviewed
Apr 12, 2024
| @@ -3,10 +3,31 @@ | |||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## v1.0dev - [date] | |||
| ## v1.0.0 - 2024-04-12 | |||
There was a problem hiding this comment.
not here, but it's nice to think about it beforehand
maxulysse
reviewed
Apr 12, 2024
maxulysse
reviewed
Apr 12, 2024
maxulysse
reviewed
Apr 12, 2024
maxulysse
reviewed
Apr 12, 2024
maxulysse
reviewed
Apr 12, 2024
There was a problem hiding this comment.
Don't think I changed anything there
There was a problem hiding this comment.
I just copied the dimensions that were in the existing image. What dimensions are preferred? The equivalent in Sarek is smaller! Width here is 600px and Sareks is 386px
maxulysse
reviewed
Apr 12, 2024
maxulysse
reviewed
Apr 12, 2024
maxulysse
reviewed
Apr 12, 2024
maxulysse
reviewed
Apr 12, 2024
maxulysse
reviewed
Apr 12, 2024
maxulysse
reviewed
Apr 12, 2024
updated changelog
…seq into v1.0.0_release_review_fixes
Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io>
V1.0.0 release review fixes
maxulysse
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review comments addressed in PR against dev: #50
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).