Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update RIBOTRICER_PREPAREORFS #77

Merged
merged 3 commits into from
Dec 4, 2024
Merged

update RIBOTRICER_PREPAREORFS #77

merged 3 commits into from
Dec 4, 2024

Conversation

iraiosub
Copy link
Contributor

@iraiosub iraiosub commented Dec 3, 2024

Update RIBOTRICER_PREPAREORFS module for increased resource allocation, because this process would often run out of memory for the human genome with the label process_single. See also nf-core/modules#7145

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/riboseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@iraiosub iraiosub added the enhancement New feature or request label Dec 3, 2024
@iraiosub iraiosub self-assigned this Dec 3, 2024
@iraiosub iraiosub requested a review from FelixKrueger December 3, 2024 19:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 1da3fc9

+| ✅ 225 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in nextflow.config: Optionally, you can add a pipeline-specific nf-core config at https://github.com/nf-core/configs
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.ribo_database_manifest
  • files_unchanged - File ignored due to lint config: assets/nf-core-riboseq_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-riboseq_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-riboseq_logo_dark.png
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore
  • actions_ci - actions_ci

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-12-04 10:36:06

FelixKrueger
FelixKrueger approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@FelixKrueger FelixKrueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks

@pinin4fjords
Copy link
Member

@nf-core-bot fix linting

@FelixKrueger FelixKrueger merged commit b525273 into nf-core:dev Dec 4, 2024
107 checks passed
@iraiosub iraiosub deleted the feat-update-ribotricer branch December 4, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelixKrueger FelixKrueger FelixKrueger approved these changes

Assignees

@iraiosub iraiosub

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iraiosub @pinin4fjords @FelixKrueger @nf-core-bot