Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python3 tag is mandatory on some large scale cluster: local changes #452

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Python3 tag is mandatory on some large scale cluster: local changes #452

merged 2 commits into from
Nov 29, 2023

Conversation

rannick
Copy link
Collaborator

@rannick rannick commented Nov 29, 2023

Replacing #450 for local change

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnafusion branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@rannick rannick marked this pull request as ready for review November 29, 2023 13:31
@rannick rannick requested a review from fevac November 29, 2023 13:31
@rannick rannick changed the title - Python3 tag is mandatory on some large scale cluster: local changes Nov 29, 2023
fevac
fevac approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@fevac fevac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 1c86d07

+| ✅ 157 tests passed       |+
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • nextflow_config - Config manifest.version should end in dev: 3.0.1
  • pipeline_todos - TODO string in WorkflowRnafusion.groovy: Optionally add in-text citation tools to this list.

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-11-29 13:33:02

@rannick rannick self-assigned this Nov 29, 2023
@rannick rannick merged commit 456d612 into dev Nov 29, 2023
8 checks passed
@rannick rannick deleted the python3 branch November 29, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fevac fevac fevac approved these changes

Assignees

@rannick rannick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rannick @fevac