Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastQ files from UMI-tools not being passed to fastp #1011

Closed
ilwookkim opened this issue Apr 25, 2023 · 0 comments · Fixed by nf-core/modules#3469
Closed

FastQ files from UMI-tools not being passed to fastp #1011

ilwookkim opened this issue Apr 25, 2023 · 0 comments · Fixed by nf-core/modules#3469
Labels
bug Something isn't working
Milestone

Comments

@ilwookkim
Copy link

Description of the bug

Hi guys,

I tried to use Fastp instead of trimglore with umi deduplciation workflow as below, and it works fine with bash script.

  1. umi tools : extract
  2. fastp
  3. star : align
  4. umi tools : dedup
  5. samtools : sort
  6. rsem

When I choose trimglore (defalut) in nfcore/rnaseq, umi tools could extract umi and could deduplicate later.
But with Fastp, all umi tags are missing on the header of bam files, therefore it could not deduplicate.
Could you fix the bug?

the examples of params files content are below:

NOT WORK:

{
"outdir": "/home/",
"with_umi": true,
"umitools_extract_method": "regex",
"umitools_bc_pattern2": "^(?P<umi_1>.{8})(?P<discard_1>.{6}).*",
"trimmer": "fastp"
}

WORK:

{
"outdir": "/home/",
"with_umi": true,
"umitools_extract_method": "regex",
"umitools_bc_pattern2": "^(?P<umi_1>.{8})(?P<discard_1>.{6}).*",
}

Thanks,
Best.

Kim

Command used and terminal output

nextflow run nf-core/rnaseq -r 3.11.1 -with-report ./nf_core.html -params-file ./nf_params.json --input ./samplesheet.csv -profile singularity -resume

Relevant files

No response

System information

No response

@ilwookkim ilwookkim added the bug Something isn't working label Apr 25, 2023
@drpatelh drpatelh added this to the 3.12 milestone May 7, 2023
@drpatelh drpatelh changed the title 'umi tools extract > Fastp >> umi tools dedup' in star-salmon workflow does not work. FastQ files from UMI-tools not being passed to fastp May 30, 2023
drpatelh added a commit to drpatelh/nf-core-rnaseq that referenced this issue May 30, 2023
@drpatelh drpatelh mentioned this issue May 31, 2023
drpatelh added a commit that referenced this issue May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants